Fix some bugs

src/core/jslib.c

@@ -55,25 +55,25 @@ EM_JS_BOOL(bool, JsvArray_Check, (JsVal obj), {
   return false;
 });
 
-EM_JS_VAL(JsVal, JsvArray_Get, (JsVal array, int idx), {
-  return nullToUndefined(array[idx]);
+EM_JS_VAL(JsVal, JsvArray_Get, (JsVal arr, int idx), {
+  return nullToUndefined(arr[idx]);
 });
 
-EM_JS_NUM(errcode, JsvArray_Set, (JsVal array, int idx, JsVal val), {
-  obj[idx] = val;
+EM_JS_NUM(errcode, JsvArray_Set, (JsVal arr, int idx, JsVal val), {
+  arr[idx] = val;
 });
 
-EM_JS_VAL(JsVal, JsvArray_Delete, (JsVal array, int idx), {
+EM_JS_VAL(JsVal, JsvArray_Delete, (JsVal arr, int idx), {
   // Weird edge case: allow deleting an empty entry, but we raise a key error if
   // access is attempted.
-  if (idx < 0 || idx >= obj.length) {
+  if (idx < 0 || idx >= arr.length) {
     return ERROR_NUM;
   }
-  return array.splice(idx, 1)[0];
+  return arr.splice(idx, 1)[0];
 });
 
-EM_JS(int, JsvArray_Push, (JsVal array, JsVal obj), {
-  return array.push(obj);
+EM_JS(int, JsvArray_Push, (JsVal arr, JsVal obj), {
+  return arr.push(obj);
 });
 
 // clang-format off
@@ -82,8 +82,8 @@ EM_JS(void, JsvArray_Extend, (JsVal arr, JsVal vals), {
 });
 // clang-format on
 
-EM_JS_NUM(JsVal, JsvArray_ShallowCopy, (JsVal obj), {
-  return ("slice" in obj) ? obj.slice() : Array.from(obj);
+EM_JS_NUM(JsVal, JsvArray_ShallowCopy, (JsVal arr), {
+  return ("slice" in arr) ? arr.slice() : Array.from(arr);
 })
 
 // clang-format off

src/core/pyproxy.ts

@@ -727,15 +727,15 @@ export class PyProxy {
   } = {}): any {
     let ptrobj = _getPtr(this);
     let idresult;
-    let proxies_id;
+    let proxies;
     let dict_converter_id = 0;
     let default_converter_id = 0;
     if (!create_pyproxies) {
-      proxies_id = 0;
+      proxies = null;
     } else if (pyproxies) {
-      proxies_id = Hiwire.new_value(pyproxies);
+      proxies = pyproxies;
     } else {
-      proxies_id = Hiwire.new_value([]);
+      proxies = [];
     }
     if (dict_converter) {
       dict_converter_id = Hiwire.new_value(dict_converter);
@@ -748,15 +748,14 @@ export class PyProxy {
       idresult = _python2js_custom(
         ptrobj,
         depth,
-        proxies_id,
+        proxies,
         dict_converter_id,
         default_converter_id,
       );
       Py_EXIT();
     } catch (e) {
       API.fatal_error(e);
     } finally {
-      Hiwire.decref(proxies_id);
       Hiwire.decref(dict_converter_id);
       Hiwire.decref(default_converter_id);
     }

src/core/python2js.c

@@ -227,6 +227,7 @@ _python2js_sequence(ConversionContext context, PyObject* x)
   success = true;
 finally:
   Py_CLEAR(pyitem);
+  hiwire_CLEAR(jsarray_ref);
   hiwire_CLEAR(jsitem);
   return success ? hiwire_new(jsarray) : NULL;
 }

src/js/types.ts

@@ -82,7 +82,7 @@ declare global {
   export const _python2js_custom: (
     obj: number,
     depth: number,
-    proxies: number,
+    proxies: PyProxy[] | null,
     dict_converter: number,
     default_converter: number,
   ) => number;

src/tests/test_jsproxy.py

@@ -252,7 +252,7 @@ def test_jsproxy_implicit_iter(selenium):
     ) == [1, 2, 3]
 
 
-def test_jsproxy_call(selenium):
+def test_jsproxy_call1(selenium):
     assert (
         selenium.run_js(
             """
@@ -271,6 +271,13 @@ def test_jsproxy_call(selenium):
         == list(range(10))
     )
 
+@run_in_pyodide
+def test_jsproxy_call2(selenium):
+    from pyodide.code import run_js
+
+    f = run_js("(function(){ return arguments.length; })")
+    assert [f(*range(n)) for n in range(10)] == list(range(10))
+
 
 def test_jsproxy_call_kwargs(selenium):
     assert (