-
-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect test cases for known bugs #1004
Comments
Usually we put non regression tests at the moment of fixing the issue, in the most appropriate test file, with the minimal example from the issue. It could indeed be useful to put tests as xfail in advance in case they got fixed by themselves after updating emscripten or some other parts of the build system. The downside is if each issue which is a bug has 2 PRs (one for test and one for the fix) it creates more activity on the issue tracker, and makes it a bit harder to follow for contributors. |
That makes sense for bugs that we are fixing quickly. The current organization scheme seems a bit limited. Issue #461 was opened on Jun 11, 2019, @mdboom opened #463 to fix it the next day, #463 was never merged, #768 was opened on October 14th 2020 about the same bug. There are a handful of bug reports in old issues that never seem to have been resolved. |
Maybe the correct solution is to be more consistent about adding the "bug" label to bug reports. |
I think we also need a "typeconversions" label, since a lot of bugs are related to that. |
We should have a
test_bugs.py
file to collect known bugs. When people file bug reports, if there is a consistent test that demonstrates the bug we should make a PR adding an xfail test and cross referencing the test against the bug report.The text was updated successfully, but these errors were encountered: