Fix #461: Handle member functions in from js import ...

[mdboom]

No description provided.

[rth]

It looks like this makes test_jsproxy_kwargs test fail...

[rth]

So the test_install_simple now failed twice in a row on Firefox (I restarted CI), with

> selenium_standalone.run("micropip.install('snowballstemmer')")
...
selenium.common.exceptions.WebDriverException: Message: NetworkError: A network error occurred.

Could it have been affected?

[mdboom]

Yeah -- I think this has broken the XHR API being used by micropip... Something about detecting the member function vs. free function is still not quite correct...

[hoodmane]

@dalcde @rth I think this should be closed, it's obsoleted by #972.

[hoodmane]

The one thing that looks interesting here is:

EM_JS(int, hiwire_is_member_function, (int idobj), {
  var jsobj = Module.hiwire_get_value(idobj);
  // clang-format off
  return (
      typeof jsobj === "function" &&
      jsobj.prototype === undefined &&
      jsobj.constructor !== undefined
  );
  // clang-format on
});

but I don't know how that works.

[rth]

I think this should be closed, it's obsoleted by #972.

You can indicate "Closes #972" in that PR description to auto-close this on merge.

[hoodmane]

@rth @dalcde Okay, #1126 was just merged which resolves #461 so I think this can be closed.