Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Python code as pypi package #1839

Closed
hoodmane opened this issue Sep 15, 2021 · 7 comments · Fixed by #3356
Closed

Release Python code as pypi package #1839

hoodmane opened this issue Sep 15, 2021 · 7 comments · Fixed by #3356
Milestone

Comments

@hoodmane
Copy link
Member

hoodmane commented Sep 15, 2021

In this discussion @grimmer0125 identified the issue that JsProxy cannot be used as a type label: static type analysis tools won't be able to suggest autocompletions and mypy etc can't typecheck the file. We already went to the trouble to make it possible to import pyodide in native Python, but we need some way to install it for the type analysis software. I think the best solution is to the Python code in src/py as a pypi package.

@grimmer0125
Copy link
Contributor

I just recently noticed this, stub https://www.python.org/dev/peps/pep-0484/#stub-files and not sure if it is another solution or not. I have no experience with it and just pass this info. Mypy's stub section

@rth
Copy link
Member

rth commented Sep 17, 2022

Yes, this would also be necessary to pass host micropip tests in pyodide/micropip#3.

How should we call this package on PyPi: pyodide-core-py ?

@rth rth modified the milestones: 0.23.0, 0.22.0 Sep 18, 2022
@rth
Copy link
Member

rth commented Sep 18, 2022

Actually another important reason we need this package on PyPi, and for it to be runnable in host as much as possible is notebooks. If someone uses any functionality (e.g. pyfetch) from this package in say JupyterLite, then download the notebook and try to run it locally, it will fail unless they are also able to pip install this package.

How should we call this package on PyPi: pyodide-core-py ?

Any objections?

@hoodmane
Copy link
Member Author

Well, it's not a great name, but I guess it gets the point across.

@rth
Copy link
Member

rth commented Sep 18, 2022

I share the sentiment. It's just that pyodide-core is technically also the FFI, and the JS package.

Maybe actually pyodide-py would be better?

@hoodmane
Copy link
Member Author

Yeah let's go with pyodide-py maybe. That also isn't fantastic but I think it has a nice enough ring to it.

At some point we could try to change the docs to call it pyodide-py more often, since we still have the confusion between pyodide the Python module accessible from JavaScript as pyodide.pyodide_py and pyodide the Javascript object importable from Python as pyodide_js.

@rth
Copy link
Member

rth commented Dec 14, 2022

I uploaded pyodide-py to PyPi some month ago, as we needed it in micropip. We still need to auto-deploy it in CI.

This was referenced Dec 14, 2022
@rth rth closed this as completed in #3356 Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants