Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Punt to Javascript for text encoding/decoding #22

Closed
mdboom opened this issue Apr 11, 2018 · 2 comments
Closed

Punt to Javascript for text encoding/decoding #22

mdboom opened this issue Apr 11, 2018 · 2 comments
Labels
bug Something isn't working cpython Javascript

Comments

@mdboom
Copy link
Collaborator

mdboom commented Apr 11, 2018

The tables for some of the larger CJK encodings are quite large in the Python implementation. There should be no need for this, since the browser / OS already has them.

We should punt out to Javascript to handle encoding/decoding for codecs that we don't ship with Pyodide -- requiring some mapping between the Python names for the codecs and the web ones.

There is a polyfill here to handle some of the cross-browser differences.

I'd consider this very low priority. Python code should generally stick to Unicode and let the input/output layer handle encoding/decoding anyway.

@mdboom mdboom added bug Something isn't working cpython Javascript labels May 22, 2018
mdboom added a commit that referenced this issue Jul 25, 2018
Obsoletes #22.  Include all codecs, since removing tests imp. size
@hoodmane
Copy link
Member

@rth @dalcde Since pr #79 supposedly obsoletes this, seems like it could be closed.

@rth
Copy link
Member

rth commented Dec 31, 2020

Thanks @hoodmane ! Closing as resolved by #79

@rth rth closed this as completed Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cpython Javascript
Projects
None yet
Development

No branches or pull requests

3 participants