Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix REPL completion #1191

Merged
merged 1 commit into from
Feb 4, 2021
Merged

Fix REPL completion #1191

merged 1 commit into from
Feb 4, 2021

Conversation

casatir
Copy link
Contributor

@casatir casatir commented Feb 3, 2021 •
edited

REPL completion in console.html has been accidentally broken by #1167 as reported by #1190.

This should resolves #1190.

@hoodmane
Copy link
Member

hoodmane commented Feb 4, 2021

Thanks @casatir!

@hoodmane
Copy link
Member

hoodmane commented Feb 4, 2021

@casatir if you say the exact words "Resolves #1190" in the PR then github will link this PR to issue #1190.

@casatir
Copy link
Contributor Author

casatir commented Feb 4, 2021

@casatir if you say the exact words "Resolves #1190" in the PR then github will link this PR to issue #1190.

Great! Thanks for the tip, I edited my post.

rth
rth approved these changes Feb 4, 2021
View reviewed changes
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @casatir and @hoodmane !

@rth rth merged commit d9fffe1 into pyodide:master Feb 4, 2021
@casatir casatir deleted the fix-repl branch February 4, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

@hoodmane hoodmane hoodmane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: e.slice is not a function in REPL
3 participants
@casatir @hoodmane @rth