Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Add isatty methods to _WriteStream and _ReadStream #1822

Merged
merged 9 commits into from Sep 8, 2021
Merged

FIX Add isatty methods to _WriteStream and _ReadStream #1822

merged 9 commits into from Sep 8, 2021

Conversation

hoodmane
Copy link
Member

@hoodmane hoodmane commented Sep 8, 2021

This resolves #1792.

rth
rth approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This could use a rudimentary test, just to make sure that code is run. Also it could use type annotations.

@hoodmane
Copy link
Member Author

hoodmane commented Sep 8, 2021

it could use type annotations

Indeed, this helped mypy notice that I just said True and not return True...

@hoodmane hoodmane merged commit dca05db into pyodide:main Sep 8, 2021
@hoodmane hoodmane deleted the console-tty branch September 8, 2021 16:41
rth pushed a commit to rth/pyodide that referenced this pull request Sep 13, 2021
@rth
FIX Add isatty methods to _WriteStream and _ReadStream (pyodide#1822)
2d27999
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AttributeError: '_WriteStream' object has no attribute 'isatty'
2 participants
@hoodmane @rth