Drop Python built-in pwd module support #1883
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops Python built-in pwd module support.
The pwd module is a Unix specific module which provides access to unix user account and passwd database.
Emscripten does not support pwd related syscalls (there is no user account in browser environment),
so currently calling pwd methods raises an error:
As CPython supports non-Unix environments (e.g. Windows), I believe dropping pwd module will cause no bad side effects.
I looked for some cases where CPython import pwd module. It handles error when pwd module is not available:
Note that other Unix specific modules like
grp
,spwd
,syslog
are already not included in pyodide.This resolves #1857, so I think this is a fix.