Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency checks for cmake (req. by emsdk) and libtool (req. by libffi) #2423

Merged
merged 1 commit into from Apr 28, 2022
Merged

Dependency checks for cmake (req. by emsdk) and libtool (req. by libffi) #2423

merged 1 commit into from Apr 28, 2022

Conversation

mdboom
Copy link
Collaborator

@mdboom mdboom commented Apr 28, 2022

Description

Add dependency checks for a couple of required things:

  • cmake (req. by emsdk)
  • libtool (req. by libffi)

Earlier errors about these should make building smoother for new contributors.

Checklists

  • Add a CHANGELOG entry
  • Add / update tests
  • Add new / update outdated documentation

hoodmane
hoodmane approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@hoodmane hoodmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mdboom!

@hoodmane hoodmane changed the title Fix #2422: Check for cmake (req. by emsdk) and libtool (req. by libffi) Dependency checks for cmake (req. by emsdk) and libtool (req. by libffi) Apr 28, 2022
@hoodmane hoodmane merged commit 5700b86 into pyodide:main Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoodmane hoodmane hoodmane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mdboom @hoodmane