Ruff is now compatible with Python pattern matching #3650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
cclauss
commented
Mar 11, 2023
cclauss
commented
Mar 13, 2023
src/tests/test_jsproxy.py
Outdated
Comment on lines
2253
to
2254
| assert o.async_ == 1 | ||
| assert o.async__ == 2 |
There was a problem hiding this comment.
Suggested change
| assert o.async_ == 1 | |
| assert o.async__ == 2 | |
| assert getattr(o, "async_") == 1 # noqa: B009 | |
| assert getattr(o, "async__") == 2 # noqa: B009 |
% ruff rule B009
get-attr-with-constant (B009)
Derived from the flake8-bugbear linter.
Autofix is always available.
Message formats:
- Do not call
getattrwith a constant attribute value. It is not any safer than normal property access.
hoodmane
approved these changes
Mar 13, 2023
|
Thanks @cclauss! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #3624
Previous versions of
ruffdid not support Python 3.11 pattern matching and treated calls to it as SyntaxErrors.pre-commit autoupdate# includes changes for psf/black 2023 stable styleChecklists