Add an argument to loadPyodide to pass environment variables #3870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also updates the command line runner to pass in all ambient environment variables. I added handling for `homedir` and `env.HOME`: if both are passed, raise an error, otherwise they mean the same thing. This changes the behavior of HOME in the command line runner: it used to point to the current working directory, but now it will point to the ambient home directory.
ryanking13
approved these changes
May 25, 2023
There was a problem hiding this comment.
Thanks, @hoodmane!
I added handling for homedir and env.HOME: if both are passed, raise an error, otherwise they mean the same thing.
Maybe we can deprecate homddir argument? Setting HOME env variable seems more natural way to set the home directory.
for more information, see https://pre-commit.ci
ryanking13
approved these changes
Jun 11, 2023
Co-authored-by: Gyeongjae Choi <def6488@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also updates the command line runner to pass in all ambient environment variables.
homediris now deprecated. I added handling forhomedirandenv.HOME: if both are passed, raise an error, otherwise they mean the same thing.Resolves #3869.