Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accessing Python reserved word attributes on js objects #3926

Merged
merged 2 commits into from Jun 14, 2023

Conversation

hoodmane
Copy link
Member

@hoodmane hoodmane commented Jun 12, 2023

And update faq. Removes some of the compatibility break in #3617.

Resolves #3921

  • Add a CHANGELOG entry
  • Add / update tests
  • Add new / update outdated documentation

@hoodmane hoodmane added this to the 0.23.3 milestone Jun 12, 2023
Copy link
Member

@ryanking13 ryanking13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hoodmane hoodmane merged commit 5454036 into pyodide:main Jun 14, 2023
1 of 2 checks passed
@hoodmane hoodmane deleted the reserved-words branch June 14, 2023 23:21
hoodmane added a commit to hoodmane/pyodide that referenced this pull request Jun 14, 2023
…3926)

Removes some of the compatibility break introduced in pyodide#3617.
Update faq too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getattr(Array, 'from') raises AttributeError
2 participants