Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Version cap pydantic<2 #3971

Merged
merged 2 commits into from Jul 1, 2023
Merged

FIX Version cap pydantic<2 #3971

merged 2 commits into from Jul 1, 2023

Conversation

timkpaine
Copy link
Contributor

@timkpaine timkpaine commented Jul 1, 2023

Description

Checklists


e.g. latest pyodide build https://github.com/pyodide/pyodide/actions/runs/5427229660/jobs/9870260314

  File "/opt/hostedtoolcache/Python/3.11.2/x64/lib/python3.11/site-packages/pyodide_build/io.py", line 30, in _SourceSpec
    @pydantic.root_validator
     ^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.2/x64/lib/python3.11/site-packages/pydantic/deprecated/class_validators.py", line 222, in root_validator
    return root_validator()(*__args)  # type: ignore
           ^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.2/x64/lib/python3.11/site-packages/pydantic/deprecated/class_validators.py", line 228, in root_validator
    raise PydanticUserError(
pydantic.errors.PydanticUserError: If you use `@root_validator` with pre=False (the default) you MUST specify `skip_on_failure=True`. Note that `@root_validator` is deprecated and should be replaced with `@model_validator`.

@timkpaine
Copy link
Contributor Author

timkpaine commented Jul 1, 2023

CC @samuelcolvin / @hoodmane

@timkpaine
Copy link
Contributor Author

timkpaine commented Jul 1, 2023

pyodide <= v0.23.3 is going to be broken so if possible please release a v0.23.4 with this version restriction if pydantic 2.0 compatibility will take time

@timkpaine timkpaine changed the title scope to pydantic<2 until compatiblity is established scope to pydantic<2 until compatiblity is added Jul 1, 2023
@hoodmane
Copy link
Member

hoodmane commented Jul 1, 2023

Thanks @timkpaine! I think we will release a Pyodide 0.23.4 with this and a few other backports.

@hoodmane
Copy link
Member

hoodmane commented Jul 1, 2023

Can you add a changelog entry?

@hoodmane hoodmane changed the title scope to pydantic<2 until compatiblity is added FIX Version cap pydantic<2 Jul 1, 2023
@hoodmane hoodmane merged commit 72a1c04 into pyodide:main Jul 1, 2023
34 of 38 checks passed
@timkpaine timkpaine deleted the tkp/pydantic branch July 1, 2023 12:49
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull request Jul 1, 2023
agoose77 added a commit to scikit-hep/awkward that referenced this pull request Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants