pyfetch: Do not raise an error on status code >= 400

[owenlamont]

Description

The previous logic was raising an OSError if a response returned a status code at 400 or greater but there are valid reasons to retrieve the bodies from such responses as they often contain additional information about the error that can be useful to the client - see issue 3974.

Checklists

• Add a CHANGELOG entry
• Add / update tests

[hoodmane]

Thanks @owenlamont. I wonder if we might want to just change raise_if_failed to raise only if bodyUsed is true? Since we should still be raising an error in that case.

[ryanking13]

Thanks @owenlamont!

I wonder if we might want to just change raise_if_failed to raise only if bodyUsed is true? Since we should still be raising an error in that case.

+1 with this.

[owenlamont]

Hope this looks better, I haven't been able to get a local build working to run tests myself - trying to follow the Linux Conda setup instructions on WSL 2 but running make gave me errors about too many open files and I tried to join the Gitter channel to ask about that, but Gitter locks up for me trying to open the pyodide community room from the link in the documentation (I had no trouble joining other rooms).

[ryanking13]

Thanks, @owenlamont! I have a minor comment about the test, otherwise looks good to me.

trying to follow the Linux Conda setup instructions on WSL 2 but running make gave me errors about too many open files

I'm not very sure about the too many open files issue but WSL2 has some issues with the file system, and it has some trouble especially when using the Windows file system in WSL2. So personally I don't recommend using WSL2 when building Pyodide.

[ryanking13]

Thanks again @owenlamont!

[owenlamont]

Thanks for all the support @ryanking13 I appreciate all the work the Pyodide devs have done.