Move stack switching logic into a new stack switching folder. #3987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a minor rearrangment. I renamed "continuations" stuff to "stack_switching" and made a new folder for stack switching logic. I also added logic in esbuild.config.mjs to calculate which functions exported from stack_switching.mjs and automatically copy them to Module and into the Emscripten namespace. This makes unit testing a little neater since there is no modification of the Module object.
rth
approved these changes
Jul 10, 2023
Makefile
Outdated
| rm -fr node_modules | ||
| shopt -s globstar && rm -fr src/**/*.o |
There was a problem hiding this comment.
On my Ubuntu system,
zsh: command not found: shopt
so it's bash specific. Not sure if it's worth having bash-specific commands here.
Similarly, MacOS has zsh so it will not work there.
There was a problem hiding this comment.
I switched to using find -delete which should hopefully work more broadly.
|
Thanks for the review @rth! |
hoodmane
added a commit
that referenced
this pull request
Jul 31, 2023
This is a minor rearrangment. I renamed "continuations" stuff to "stack_switching" and made a new folder for stack switching logic. I also added logic in esbuild.config.mjs to calculate which functions exported from stack_switching.mjs and automatically copy them to Module and into the Emscripten namespace. This makes unit testing a little neater since there is no modification of the Module object.
hoodmane
added a commit
that referenced
this pull request
Sep 13, 2023
This is a minor rearrangment. I renamed "continuations" stuff to "stack_switching" and made a new folder for stack switching logic. I also added logic in esbuild.config.mjs to calculate which functions exported from stack_switching.mjs and automatically copy them to Module and into the Emscripten namespace. This makes unit testing a little neater since there is no modification of the Module object.
hoodmane
added a commit
to hoodmane/pyodide
that referenced
this pull request
Sep 15, 2023
…e#3987) This is a minor rearrangment. I renamed "continuations" stuff to "stack_switching" and made a new folder for stack switching logic. I also added logic in esbuild.config.mjs to calculate which functions exported from stack_switching.mjs and automatically copy them to Module and into the Emscripten namespace. This makes unit testing a little neater since there is no modification of the Module object.
hoodmane
added a commit
to hoodmane/pyodide
that referenced
this pull request
Oct 19, 2023
…e#3987) This is a minor rearrangment. I renamed "continuations" stuff to "stack_switching" and made a new folder for stack switching logic. I also added logic in esbuild.config.mjs to calculate which functions exported from stack_switching.mjs and automatically copy them to Module and into the Emscripten namespace. This makes unit testing a little neater since there is no modification of the Module object.
hoodmane
added a commit
that referenced
this pull request
Oct 21, 2023
This is a minor rearrangment. I renamed "continuations" stuff to "stack_switching" and made a new folder for stack switching logic. I also added logic in esbuild.config.mjs to calculate which functions exported from stack_switching.mjs and automatically copy them to Module and into the Emscripten namespace. This makes unit testing a little neater since there is no modification of the Module object.
lesteve
pushed a commit
to lesteve/pyodide
that referenced
this pull request
Nov 13, 2023
…e#3987) This is a minor rearrangment. I renamed "continuations" stuff to "stack_switching" and made a new folder for stack switching logic. I also added logic in esbuild.config.mjs to calculate which functions exported from stack_switching.mjs and automatically copy them to Module and into the Emscripten namespace. This makes unit testing a little neater since there is no modification of the Module object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor rearrangment.
I renamed "continuations" stuff to "stack_switching" and made a new folder for stack switching logic. I also added logic in esbuild.config.mjs to calculate which functions exported from stack_switching.mjs and automatically copy them to Module and into the Emscripten namespace. This makes unit testing a little neater since there is no modification of the Module object.