Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emscripten 3.1.45 #4094

Merged
merged 6 commits into from Aug 29, 2023
Merged

Emscripten 3.1.45 #4094

merged 6 commits into from Aug 29, 2023

Conversation

hoodmane
Copy link
Member

@hoodmane hoodmane commented Aug 26, 2023

  • Update changelog

@hoodmane
Copy link
Member Author

Building numcodecs failed:

clang: error: unsupported option '-mno-sse2' for target 'wasm32-unknown-emscripten'
clang: error: unsupported option '-mno-avx2' for target 'wasm32-unknown-emscripten'

@ryanking13
Copy link
Member

It looks like previously llvm ignored those SIMD flags, but now it throws an error. In the build log of the main branch:

clang: warning: argument unused during compilation: '-mno-sse2' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-mno-avx2' [-Wunused-command-line-argument]

Those flags are added by DISABLE_NUMCODECS_SSE2, DISABLE_NUMCODECS_AVX2 env variables. So let's remove them and see what happens.

@hoodmane
Copy link
Member Author

That fails too:

emcc: error: Passing any of -msse, -msse2, -msse3, -mssse3, -msse4.1, -msse4.2, 
-msse4, -mavx, -mfpu=neon flags also requires passing -msimd128 (or             
-mrelaxed-simd)! 

How about filtering -mno-sse2 in pywasmcross?

@ryanking13
Copy link
Member

Yes, it looks like we need to filter out SIMD flags in pywasmcross, until we support SIMD.

How about filtering -mno-sse2 in pywasmcross?

-mno-sse2 and -mno-avx are removed, but other flags remain, so I guess we should filter out -msse, -msse2, -msse3, -mssse3, -msse4.1, -msse4.2, -msse4, -mavx.

@hoodmane
Copy link
Member Author

It's really annoying how build-packages-no-numpy-dependents times out so often these days...

@ryanking13
Copy link
Member

ryanking13 commented Aug 29, 2023

Indeed... I'll start working on #3827 again after the release so we don't have to build whole packages on every commit.

@hoodmane hoodmane merged commit df527fd into pyodide:main Aug 29, 2023
0 of 2 checks passed
@hoodmane hoodmane deleted the emscripten-3.1.45 branch August 29, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants