ENH Add loadPyodide packages option for loading packages during bootstrap
#4100
Conversation
…Pyodide is bootstrapped For improved loading performance.
| return Buffer.from(b16, "hex").toString("base64"); | ||
| } | ||
|
|
||
| function browserBase16ToBase64(b16: string): string { |
There was a problem hiding this comment.
Is this because btoa is not supported in Node < 16.0?
If so, the lifecycle of Node 14 was ended a few months ago, and Node 16 will also retire soon (in a few weeks), so I think we can think of dropping support for older Node versions to reduce the maintenance burden.
(no action required for this PR)
There was a problem hiding this comment.
Let's officially drop node 14 support after the release?
There was a problem hiding this comment.
It does say on the node atob api docs:
This function is only provided for compatibility with legacy web platform APIs and should never be used in new code, because they use strings to represent binary data and predate the introduction of typed arrays in JavaScript. For code running using Node.js APIs, converting between base64-encoded strings and binary data should be performed using
Buffer.from(str, 'base64')andbuf.toString('base64').
But probably we should reasonably ignore this?
|
Thanks for the review @ryanking13. |
For improved loading performance.