feat: add awkward-cpp v22 #4101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…yodide into agoose77/feat-add-awkward-cpp
ryanking13
reviewed
Aug 30, 2023
There was a problem hiding this comment.
Thanks @agoose77! Could you add some basic tests for awkward-cpp?
| build: | ||
| script: | | ||
| export CMAKE_ARGS="${CMAKE_ARGS} -DEMSCRIPTEN=1" | ||
| exports: whole_archive |
There was a problem hiding this comment.
What happens if you don't set whole_archive?
There was a problem hiding this comment.
It used to be the case that some symbols were missing. Right now I can't seem to test this locally; I'm getting
OSError: [Errno 7] Argument list too long: 'em++'
I don't recall this happening before.
There was a problem hiding this comment.
I think it's okay for now then then, we have a bug in our symbol logic that causes this Argument list too long error when there are a lot of exported symbols.
Co-authored-by: Gyeongjae Choi <def6488@gmail.com>
…yodide into agoose77/feat-add-awkward-cpp
for more information, see https://pre-commit.ci
hoodmane
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the awkward-cpp package.
Checklists