Add zengl 1.16.0

[szabolcsdombi]

Description

Added zengl 1.16.0

ZenGL provides OpenGL binding for Python.
The same code that runs natively also runs in the browser as-is without modifications.
It does not depend on SDL, emscripten GLES or anything else.
It binds directly to WebGL2.

Working demo: https://szabolcsdombi.github.io/zengl/

Checklists

• Add a CHANGELOG entry
• Add / update tests
• Add new / update outdated documentation

[szabolcsdombi]

I am running the tests from ./run_docker.sh as follows:

szabi@bf7ba56f9cb2:/src$ pytest --runtime chrome -k zengl
============================================================================================ test session starts =============================================================================================
platform linux -- Python 3.11.3, pytest-7.3.1, pluggy-1.0.0
benchmark: 4.0.0 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000)
rootdir: /src
configfile: pyproject.toml
testpaths: src, pyodide-build, packages
plugins: pyodide-0.23.2, asyncio-0.21.0, cov-4.0.0, benchmark-4.0.0, httpserver-1.0.6, hypothesis-6.75.2
asyncio: mode=Mode.STRICT
collected 2177 items / 2174 deselected / 3 selected                                                                                                                                                          

packages/_tests/test_packages_common.py .s                                                                                                                                                             [ 66%]
packages/zengl/test_zengl.py s                                                                                                                                                                         [100%]

============================================================================================== warnings summary ==============================================================================================
pyodide-build/pyodide_build/buildpkg.py:8
  /src/pyodide-build/pyodide_build/buildpkg.py:8: DeprecationWarning: 'cgi' is deprecated and slated for removal in Python 3.13
    import cgi

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
========================================================================== 1 passed, 2 skipped, 2174 deselected, 1 warning in 3.48s ==========================================================================
szabi@bf7ba56f9cb2:/src$ 

my package is built:

szabi@bf7ba56f9cb2:/src$ pyodide build-recipes zengl
The following packages are already built: distutils, hashlib, liblzma, lzma, micropip, openssl, packaging, pydecimal, pydoc_data, sqlite3, ssl, test, and zengl                                               
All packages already built. Quitting.

[ryanking13]

I am running the tests from ./run_docker.sh as follows:

Sorry, you need to update pytest-pyodide version in the docker image before running the test.

pip install -U pytest-pyodide

The CI looks good generally. Could you add @pytest.mark.driver_timeout(60) decorator on your tests to increase the test timeout?

[szabolcsdombi]

thank you, it works now.

_tests/test_packages_common.py::parse_package[zengl] PASSED                                      [ 33%]
_tests/test_packages_common.py::import[chrome-zengl] PASSED                                      [ 66%]
zengl/test_zengl.py::render_with_webgl2[chrome] <- .docker_home/.../decorator.py PASSED          [100%]

[szabolcsdombi]

Here is a complete list of commands to achieve running tests:

./run_docker
pip install -U pytest-pyodide
PYODIDE_PACKAGES=zengl make
pytest --runtime chrome -k zengl -vvv

Previously I did:

./run_docker
make
pyodide build-recipes zengl # this will build zengl but it won't be visible for the tests, see the commands above
pytest ...

[hoodmane]

Looks like this is ready to merge.

[hoodmane]

Thanks @szabolcsdombi!

[hoodmane]

It is still timing out on firefox. Maybe xfail it?

[szabolcsdombi]

would xfail waste a minute?

getContext returns null or undefined.
getContext only works for '2d' in this firefox.

skip does not work either.

if not gl:
    pytest.skip('webgl2 not supported')  # raises Skipped and cannot be pickled

so i moved the context creation behind an if.

[szabolcsdombi]

• rebased on top of main
• fixed the changelog conflict
• squashed commits

[hoodmane]

Interesting I'll look into fixing pytest.skip inside of @run_in_pyodide.

[szabolcsdombi]

I have looked into that, forked pytest-pyodide, but I found it too hard to track down the place to add my changes. Namely I found no way to nicely catch and re-raise exceptions first propagating through the js invocation in the run method of the base class.

pytest.skip(msg) just raises Skipped(msg) nothing special there.

I would love to help.

[hoodmane]

Thanks for contributing this @szabolcsdombi! It looks very nice.

I have looked into that, forked pytest-pyodide, but I found it too hard to track down the place to add my changes.

Well thanks for looking into it. It is a bit of a confusing package...

[hoodmane]

The problem is here:
https://github.com/pytest-dev/pytest/blob/main/src/_pytest/outcomes.py#L44-L46
We need to modify the pickler to be aware of this:
https://github.com/pyodide/pytest-pyodide/blob/main/pytest_pyodide/decorator.py#L59-L63

[szabolcsdombi]

Thank you!