Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch PyProxy.toString from repr to str #4247

Merged
merged 5 commits into from Oct 23, 2023
Merged

Switch PyProxy.toString from repr to str #4247

merged 5 commits into from Oct 23, 2023

Conversation

hoodmane
Copy link
Member

@hoodmane hoodmane commented Oct 22, 2023 •
edited

Resolves #4040.

  • Add a CHANGELOG entry
  • Add / update tests
  • Add new / update outdated documentation

@hoodmane
Copy link
Member Author

Astonishingly, it looks like we didn't have a single unit test that cares about this??

@hoodmane
Copy link
Member Author

I added more string related entries to the type-conversions.md. There are a lot of things missing from type-conversions.md, I will hopefully go through and update it when I have a moment.

ryanking13
ryanking13 approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@ryanking13 ryanking13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/js/pyodide.ts Outdated Show resolved Hide resolved
@hoodmane hoodmane merged commit 53fbd00 into pyodide:main Oct 23, 2023
40 checks passed
@hoodmane hoodmane deleted the toString-str branch October 23, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanking13 ryanking13 ryanking13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question: Should toString use __repr__ or __str__?
2 participants
@hoodmane @ryanking13