Add --config-setting flag to pyodide build
command.
#4308
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
--config-setting
(-C
) flag topyodide build
command, to make it compatible topython -m build
.Previously, we were passing any extra parameters to config-settings. For example, if someone wanted to run a build command like
python -m build -C--key=value
, they should have to runpyodide build --key=value
. But now they can dopyodide build -C--key=value
.For backward compatibility, this PR does not drop the old behavior. So
pyodide build --key=value
will still work.Related: numpy/numpy#24603 (comment)
Checklists