Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stdin reader to avoid treating empty strings as EOF #4327

Merged
merged 4 commits into from Dec 6, 2023
Merged

Fix stdin reader to avoid treating empty strings as EOF #4327

merged 4 commits into from Dec 6, 2023

Conversation

ryanking13
Copy link
Member

@ryanking13 ryanking13 commented Dec 5, 2023 •
edited

Description

Close #4258

Checklists

  • Add a CHANGELOG entry
  • Add / update tests
  • Add new / update outdated documentation

@hoodmane
Copy link
Member

hoodmane commented Dec 5, 2023

Thanks @ryanking13. I tried this a while back and I thought there was a problem with it but probably I was over complicating things.

@ryanking13
Copy link
Member Author

Thanks for the review!

@ryanking13 ryanking13 merged commit 2711fad into pyodide:main Dec 6, 2023
36 of 39 checks passed
@ryanking13 ryanking13 deleted the stream-empty branch December 6, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoodmane hoodmane hoodmane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with stdin and empty strings using Node.js
2 participants
@ryanking13 @hoodmane