Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pacakge nh3 #4387

Merged
merged 4 commits into from Jan 18, 2024
Merged

Add pacakge nh3 #4387

merged 4 commits into from Jan 18, 2024

Conversation

hoodmane
Copy link
Member

@hoodmane hoodmane commented Jan 17, 2024 •
edited

Resolves #4381.

@hoodmane hoodmane mentioned this pull request Jan 17, 2024
Closed
ryanking13
ryanking13 approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@ryanking13 ryanking13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hoodmane!

I like the name of the package, by the way. ammonia and nh3 :)

@hoodmane hoodmane merged commit b049683 into pyodide:main Jan 18, 2024
35 of 36 checks passed
@hoodmane hoodmane deleted the nh3 branch January 18, 2024 18:25
@MarcSkovMadsen
Copy link

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanking13 ryanking13 ryanking13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nh3
3 participants
@hoodmane @MarcSkovMadsen @ryanking13