Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New packages flint, python-flint #4410

Merged
merged 9 commits into from Jan 28, 2024
Merged

New packages flint, python-flint #4410

merged 9 commits into from Jan 28, 2024

Conversation

mkoeppe
Copy link
Sponsor Contributor

@mkoeppe mkoeppe commented Jan 23, 2024 •
edited

Description

Checklists

@mkoeppe mkoeppe mentioned this pull request Jan 23, 2024
Open
@mkoeppe mkoeppe force-pushed the flint branch 2 times, most recently from b2c3b78 to 9178eff Compare January 25, 2024 04:29
@mkoeppe mkoeppe marked this pull request as draft January 25, 2024 06:14
@mkoeppe mkoeppe changed the title New packages flint, e_antic New packages flint, python-flint, e_antic, normaliz, pynormaliz Jan 25, 2024
@mkoeppe mkoeppe force-pushed the flint branch 3 times, most recently from 082b6e1 to 99cf5ea Compare January 27, 2024 06:05
@mkoeppe mkoeppe changed the title New packages flint, python-flint, e_antic, normaliz, pynormaliz New packages flint, python-flint Jan 27, 2024
@mkoeppe mkoeppe marked this pull request as ready for review January 27, 2024 18:50
hoodmane
hoodmane approved these changes Jan 27, 2024
View reviewed changes
Copy link
Member

@hoodmane hoodmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks again @mkoeppe for all your recent contributions, we really appreciate it.

@hoodmane
Copy link
Member

Seems like you need to declare numpy as a build time dependency of python-flint?

@mkoeppe
Copy link
Sponsor Contributor Author

mkoeppe commented Jan 27, 2024

Thanks. Not any more with the patch just added.

@hoodmane hoodmane merged commit 1b21d72 into pyodide:main Jan 28, 2024
40 of 41 checks passed
@mkoeppe mkoeppe deleted the flint branch January 28, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoodmane hoodmane hoodmane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkoeppe @hoodmane