Remove node-fetch fallback #4417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
reviewed
Jan 24, 2024
docs/project/changelog.md
Outdated
Comment on lines
29
to
30
| - {{ Breaking }} Pyodide will not fallback to `node-fetch` anymore when `fetch` | ||
| is not available in the Node.js environment. |
There was a problem hiding this comment.
Is this really breaking since we already said we don't support Node 16? Maybe mention Node 16 in the message too?
There was a problem hiding this comment.
Thanks. I updated the changelog that it affects Node.js < 18.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drops node-fetch fallback and add
engineskey to package.json.Related: #4411
It is worth noting that the
engineskey is just for advisory only, so it will not prevent people from installing Pyodide in older Node versions... but at least we can tell users that we don't support old node versions anymore.Checklists