Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenBLAS to 0.26 #4526

Merged
merged 2 commits into from Feb 17, 2024
Merged

Update OpenBLAS to 0.26 #4526

merged 2 commits into from Feb 17, 2024

Conversation

lesteve
Copy link
Contributor

@lesteve lesteve commented Feb 17, 2024

Description

This updates to OpenBLAS 0.26 released in January 2024.

It looks like one of the Pyodide patch replacing ar by emar is not needed after OpenMathLib/OpenBLAS#4344.

I ran locally https://github.com/lesteve/scipy-tests-pyodide and did not find any new issues in Scipy with this PR.

I did not look at performance impact but quickly glancing at the OpenBLAS changelog, nothing jumped at me as "this will definitely have an impact on Pyodide".

Checklists

  • Add a CHANGELOG entry
  • Add / update tests
  • Add new / update outdated documentation

Copy link
Member

@ryanking13 ryanking13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @lesteve!

@ryanking13 ryanking13 merged commit 8d15ba9 into pyodide:main Feb 17, 2024
41 checks passed
@lesteve lesteve deleted the openblas-0.26 branch February 18, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants