Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mountNodeFS #4561

Merged
merged 3 commits into from Feb 26, 2024
Merged

Add mountNodeFS #4561

merged 3 commits into from Feb 26, 2024

Conversation

hoodmane
Copy link
Member

@hoodmane hoodmane commented Feb 24, 2024 •
edited

This is a helper function for mounting native directories in node, analogous to mountNativeFS.

  • Add a CHANGELOG entry
  • Add / update tests
  • Add new / update outdated documentation

@hoodmane hoodmane force-pushed the mountNodeFS branch 2 times, most recently from 6327a53 to 18ee1d4 Compare February 24, 2024 22:08
@hoodmane hoodmane mentioned this pull request Feb 24, 2024
Merged
@hoodmane
Add mountNodeFS
f824093 
This is a helper function for mounting native directories in node, analogous to
mountNativeFS
@hoodmane
Update changelog
549009a
ryanking13
ryanking13 approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@ryanking13 ryanking13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/js/api.ts Show resolved Hide resolved
docs/project/changelog.md Outdated Show resolved Hide resolved
@hoodmane
Copy link
Member Author

Thanks for the review @ryanking13!

@hoodmane hoodmane merged commit 0fc565f into pyodide:main Feb 26, 2024
21 of 22 checks passed
@hoodmane hoodmane deleted the mountNodeFS branch February 26, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanking13 ryanking13 ryanking13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hoodmane @ryanking13