Don't throw when calling str on a proxy without a toString method #4574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanking13
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Thanks for the quick fix @hoodmane! It seems like toString() results slightly differs by browsers, otherwise LGTM.
accessing obj.toString succeeds and returns a function, but calling the function throws
accessing obj.toString fails or returns not a function, and Object.prototype.toString.call fails.
I think this is reasonable enough.
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4569. It still doesn't make sure
str(jsproxy)never throws. It will throw if:obj.toStringsucceeds and returns a function, but calling the function throwsobj.toStringfails or returns not a function, andObject.prototype.toString.callfails.See added tests. Sound reasonable @ryanking13? cc @CNSeniorious000.