Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PKG Add pygame-ce #4602
PKG Add pygame-ce #4602
Changes from 27 commits
9596a36
98a7af3
75ff0e1
af6d119
c66cb4c
c12a435
402d56e
ddd37e4
00c6e72
393865b
55a8045
91ce858
b2444fc
9ab4c1b
f0fefa7
8055e67
99d8dcc
b876d05
13317a2
307a112
b1630aa
acd9ff2
0e7a564
e281ea8
2dd154c
cafc000
cca8664
96893dc
2632d44
ed79ffe
4cb7d17
a149897
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is true for pygame-web but not true for Pyodide.
cc: @pmp-p
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm making pygame-community/pygame-ce#2748 so both pygame-web and pyodide do not require patching
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much! I don't know anything about pygame internals, so I really appreciate the various things you do for WASM support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, we appreciate all the work you've done on this @pmp-p -- it seems like quite a lot of effort.