Add asJsonAdaptor to PyProxy of Sequence or Map #4666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Designed to make dictionaries + lists behave like JavaScript JSON so that `JSON.stringify`, `Response.json`, etc work as expected and direct access like `a[0].b.c[1].d` works. I think this is how `as_object_map()` should have behaved all along. As a followup, I'd also like to add a symmetric `as_json_adaptor()` to JsProxy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Designed to make dictionaries + lists behave like JavaScript JSON so that
JSON.stringify,Response.json, etc work as expected and direct access likea[0].b.c[1].dworks. I think this is howas_object_map()should have behaved all along. As a followup, I'd also like to add a symmetricas_json_adaptor()to JsProxy.