Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

full string as method for ode solvers #415

Merged
merged 6 commits into from
Dec 31, 2021
Merged

Conversation

Ipuch
Copy link
Collaborator

@Ipuch Ipuch commented Dec 8, 2021

All Submissions:

  • Have you followed the guidelines in our Contributing document [docs/contribution.md]?
  • Have you checked to ensure there aren't other open [Pull Requests] for the same update/change?
  • Have you opened/linked the issue related to your pull request?
  • Have you used the tag [WIP] for on-going changes, and removed it when the pull request was ready?
  • When ready to merge, have you sent a comment pinging @pariterre in it?

New Feature Submissions:

  1. Does your submission pass the tests (if not please explain why this is intended)?
  2. Did you write a proper documentation (docstrings and ReadMe)
  3. Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new examples for your core changes, as applicable?
  • Have you written new tests for your core changes, as applicable?

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Good catch :)

@codecov
Copy link

codecov bot commented Dec 31, 2021

Codecov Report

Merging #415 (b3630d1) into master (fd01562) will decrease coverage by 0.05%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
- Coverage   80.62%   80.57%   -0.06%     
==========================================
  Files          81       81              
  Lines        8398     8407       +9     
==========================================
+ Hits         6771     6774       +3     
- Misses       1627     1633       +6     
Impacted Files Coverage Δ
bioptim/dynamics/ode_solver.py 87.50% <33.33%> (-5.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cc664b...b3630d1. Read the comment docs.

@pariterre pariterre merged commit 7212f5a into pyomeca:master Dec 31, 2021
@Ipuch Ipuch deleted the ode_solver_str branch January 3, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants