Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignored plots for phase_transition #433

Merged
merged 6 commits into from
Mar 9, 2022

Conversation

EveCharbie
Copy link
Collaborator

I don't think it should be merged since it is really a patch and not a fix.
But this way it is available to others, in the mean time :)

@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #433 (15c3db6) into master (61e7951) will decrease coverage by 0.02%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #433      +/-   ##
==========================================
- Coverage   80.21%   80.18%   -0.03%     
==========================================
  Files          83       83              
  Lines        8761     8768       +7     
==========================================
+ Hits         7028     7031       +3     
- Misses       1733     1737       +4     
Impacted Files Coverage Δ
...tim/examples/getting_started/example_multiphase.py 90.90% <0.00%> (-1.69%) ⬇️
bioptim/optimization/optimal_control_program.py 88.45% <0.00%> (ø)
bioptim/gui/plot.py 76.00% <57.14%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61e7951...15c3db6. Read the comment docs.

@pariterre
Copy link
Member

If you do not think it worths merging there is not really a point to PR it, as anyone can still connect to your fork and merge locally even if no PR is open :)

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GG so far! :)

bioptim/gui/plot.py Outdated Show resolved Hide resolved
bioptim/examples/getting_started/example_multiphase.py Outdated Show resolved Hide resolved
@Ipuch
Copy link
Collaborator

Ipuch commented Mar 9, 2022

ready to merge @pariterre

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pariterre pariterre merged commit 973a7b8 into pyomeca:master Mar 9, 2022
@Ipuch Ipuch mentioned this pull request Apr 13, 2022
@EveCharbie EveCharbie deleted the Graphs_objConst_miltiPhase branch May 30, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants