-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignored plots for phase_transition #433
Ignored plots for phase_transition #433
Conversation
Codecov Report
@@ Coverage Diff @@
## master #433 +/- ##
==========================================
- Coverage 80.21% 80.18% -0.03%
==========================================
Files 83 83
Lines 8761 8768 +7
==========================================
+ Hits 7028 7031 +3
- Misses 1733 1737 +4
Continue to review full report at Codecov.
|
If you do not think it worths merging there is not really a point to PR it, as anyone can still connect to your fork and merge locally even if no PR is open :) |
I found how to plot multiple phase transition contraints.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GG so far! :)
ready to merge @pariterre |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I don't think it should be merged since it is really a patch and not a fix.
But this way it is available to others, in the mean time :)