Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the user to not expand the dynamics if wanted #454

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

Ipuch
Copy link
Collaborator

@Ipuch Ipuch commented Apr 1, 2022

All Submissions:

  • Have you followed the guidelines in our Contributing document [docs/contribution.md]?
  • Have you checked to ensure there aren't other open [Pull Requests] for the same update/change?
  • Have you opened/linked the issue related to your pull request?
  • Have you used the tag [WIP] for ongoing changes and removed it when the pull request was ready?
  • When ready to merge, have you sent a comment pinging @pariterre in it?

New Feature Submissions:

  1. Does your submission pass the tests (if not, please explain why this is intended)?
  2. Did you write proper documentation (docstrings and ReadMe)
  3. Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new examples for your core changes, as applicable?
  • Have you written new tests for your core changes, as applicable?

This PR is merely intended for custom dynamics.


This change is Reviewable

@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #454 (4aa35f7) into master (0a86e9a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #454   +/-   ##
=======================================
  Coverage   80.48%   80.48%           
=======================================
  Files          85       85           
  Lines        8996     8998    +2     
=======================================
+ Hits         7240     7242    +2     
  Misses       1756     1756           
Impacted Files Coverage Δ
bioptim/dynamics/configure_problem.py 91.30% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a86e9a...4aa35f7. Read the comment docs.

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Ipuch)

@pariterre
Copy link
Member

That is PR as I like them!
LGTM :)

@pariterre pariterre merged commit 2f86098 into pyomeca:master Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants