-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Muscle implicit dynamics #459
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @aceglia)
bioptim/examples/acados/pendulum.py
line 116 at r1 (raw file):
# --- Show results --- # sol.print_cost()
Is there a reason to showcase only print_cost?
bioptim/interfaces/solver_options.py
line 569 at r1 (raw file):
self.set_has_tolerance_changed(True) def set_convergence_tolerance(self, val):
val: Union[float, int, list, tuple]
Please add documentation for this method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 6 of 7 files reviewed, 2 unresolved discussions (waiting on @pariterre)
bioptim/examples/acados/pendulum.py
line 116 at r1 (raw file):
Previously, pariterre (Pariterre) wrote…
Is there a reason to showcase only print_cost?
there was a sol.print() before, to make the example work I simply replaced it with a sol.print_cost(). No deeper reason.
bioptim/interfaces/solver_options.py
line 569 at r1 (raw file):
Previously, pariterre (Pariterre) wrote…
val: Union[float, int, list, tuple]
Please add documentation for this method
Done.
Codecov Report
@@ Coverage Diff @@
## master #459 +/- ##
==========================================
- Coverage 80.56% 80.23% -0.34%
==========================================
Files 85 85
Lines 9080 9257 +177
==========================================
+ Hits 7315 7427 +112
- Misses 1765 1830 +65
Continue to review full report at Codecov.
|
@aceglia les tests passent en ligne :) |
@pariterre tests ok! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, 5 of 5 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @aceglia)
No handle the fatigue and the activation dynamics.
This change is