Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Muscle implicit dynamics #459

Merged
merged 18 commits into from
Jun 16, 2022
Merged

Muscle implicit dynamics #459

merged 18 commits into from
Jun 16, 2022

Conversation

aceglia
Copy link
Contributor

@aceglia aceglia commented Apr 20, 2022

No handle the fatigue and the activation dynamics.


This change is Reviewable

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @aceglia)


bioptim/examples/acados/pendulum.py line 116 at r1 (raw file):

    # --- Show results --- #
    sol.print_cost()

Is there a reason to showcase only print_cost?


bioptim/interfaces/solver_options.py line 569 at r1 (raw file):

            self.set_has_tolerance_changed(True)

        def set_convergence_tolerance(self, val):

val: Union[float, int, list, tuple]
Please add documentation for this method

Copy link
Contributor Author

@aceglia aceglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 6 of 7 files reviewed, 2 unresolved discussions (waiting on @pariterre)


bioptim/examples/acados/pendulum.py line 116 at r1 (raw file):

Previously, pariterre (Pariterre) wrote…

Is there a reason to showcase only print_cost?

there was a sol.print() before, to make the example work I simply replaced it with a sol.print_cost(). No deeper reason.


bioptim/interfaces/solver_options.py line 569 at r1 (raw file):

Previously, pariterre (Pariterre) wrote…

val: Union[float, int, list, tuple]
Please add documentation for this method

Done.

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #459 (617361f) into master (6aff2c1) will decrease coverage by 0.33%.
The diff coverage is 62.10%.

@@            Coverage Diff             @@
##           master     #459      +/-   ##
==========================================
- Coverage   80.56%   80.23%   -0.34%     
==========================================
  Files          85       85              
  Lines        9080     9257     +177     
==========================================
+ Hits         7315     7427     +112     
- Misses       1765     1830      +65     
Impacted Files Coverage Δ
bioptim/examples/acados/pendulum.py 84.21% <0.00%> (+2.15%) ⬆️
bioptim/examples/acados/static_arm.py 42.85% <0.00%> (ø)
bioptim/examples/fatigue/pendulum_with_fatigue.py 82.60% <0.00%> (ø)
...ioptim/examples/fatigue/static_arm_with_fatigue.py 67.85% <0.00%> (ø)
...amples/getting_started/custom_phase_transitions.py 92.75% <0.00%> (ø)
...mples/getting_started/example_implicit_dynamics.py 44.92% <0.00%> (ø)
...s/getting_started/example_multinode_constraints.py 90.16% <0.00%> (ø)
.../examples/getting_started/example_save_and_load.py 64.10% <0.00%> (ø)
.../examples/moving_horizon_estimation/cyclic_nmpc.py 63.88% <0.00%> (ø)
...les/moving_horizon_estimation/multi_cyclic_nmpc.py 66.66% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e0995d...617361f. Read the comment docs.

@Ipuch
Copy link
Collaborator

Ipuch commented Jun 14, 2022

@aceglia les tests passent en ligne :)

@aceglia
Copy link
Contributor Author

aceglia commented Jun 14, 2022

@pariterre tests ok!

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, 5 of 5 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @aceglia)

@pariterre pariterre merged commit b108024 into pyomeca:master Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants