Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tested examples #475

Merged
merged 1 commit into from
Jun 9, 2022
Merged

tested examples #475

merged 1 commit into from
Jun 9, 2022

Conversation

Sciancisco
Copy link
Contributor

@Sciancisco Sciancisco commented May 30, 2022 •
edited

All Submissions:

  • Have you followed the guidelines in our Contributing document [docs/contribution.md]?
  • Have you checked to ensure there aren't other open [Pull Requests] for the same update/change?
  • Have you opened/linked the issue related to your pull request?
  • Have you used the tag [WIP] for on-going changes, and removed it when the pull request was ready?
  • When ready to merge, have you sent a comment pinging @pariterre in it?

related to #468
@pariterre

This change is Reviewable

@Sciancisco
tested examples
de87751 
examples tested (bioptim/examples):
- muscle_driven_with_contact/*
- muscle_driven_ocp/*
- moving_horizon_estimations/*
@Ipuch
Copy link
Collaborator

Ipuch commented May 30, 2022

Thanks @Sciancisco
PR is related to #468

pariterre
pariterre approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Sciancisco)

@pariterre pariterre merged commit 092d48f into pyomeca:master Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pariterre pariterre pariterre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sciancisco @Ipuch @pariterre