-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RTM] NoisedInitialGuess properly scale within bounds #506
Conversation
Codecov Report
@@ Coverage Diff @@
## master #506 +/- ##
==========================================
- Coverage 80.44% 80.39% -0.05%
==========================================
Files 86 86
Lines 9475 9484 +9
==========================================
+ Hits 7622 7625 +3
- Misses 1853 1859 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Ipuch)
bioptim/limits/path_conditions.py
line 928 at r2 (raw file):
# building the noise matrix self.noise = (
add self.noise = None
in the init
Code quote:
self.noise
bioptim/limits/path_conditions.py
line 938 at r2 (raw file):
) # building the noised initial guess self.noised_initial_guess = init_instance.init + self.noise
add self.noised_initial_guess = None
in the init
Code quote:
self.noised_initial_guess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Ipuch)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Ipuch)
All Submissions:
New Feature Submissions:
black . -l120 --exclude "external/*"
)?Changes to Core Features:
This change is