Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTM] NoisedInitialGuess properly scale within bounds #506

Merged
merged 8 commits into from
Aug 8, 2022

Conversation

Ipuch
Copy link
Collaborator

@Ipuch Ipuch commented Jul 29, 2022

All Submissions:

  • Have you followed the guidelines in our Contributing document [docs/contribution.md]?
  • Have you checked to ensure there aren't other open [Pull Requests] for the same update/change?
  • Have you opened/linked the issue related to your pull request?
  • Have you used the tag [WIP] for on-going changes, and removed it when the pull request was ready?
  • When ready to merge, have you sent a comment pinging @pariterre in it?

New Feature Submissions:

  1. Does your submission pass the tests (if not please explain why this is intended)?
  2. Did you write a proper documentation (docstrings and ReadMe)
  3. Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new examples for your core changes, as applicable?
  • Have you written new tests for your core changes, as applicable?

This change is Reviewable

@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #506 (3f94a90) into master (8832de4) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #506      +/-   ##
==========================================
- Coverage   80.44%   80.39%   -0.05%     
==========================================
  Files          86       86              
  Lines        9475     9484       +9     
==========================================
+ Hits         7622     7625       +3     
- Misses       1853     1859       +6     
Impacted Files Coverage Δ
bioptim/limits/path_conditions.py 84.34% <100.00%> (+0.10%) ⬆️
bioptim/examples/acados/pendulum.py 80.00% <0.00%> (-4.22%) ⬇️
bioptim/optimization/solution.py 85.56% <0.00%> (-0.57%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Ipuch)


bioptim/limits/path_conditions.py line 928 at r2 (raw file):

        # building the noise matrix
        self.noise = (

add self.noise = None in the init

Code quote:

self.noise

bioptim/limits/path_conditions.py line 938 at r2 (raw file):

        )
        # building the noised initial guess
        self.noised_initial_guess = init_instance.init + self.noise

add self.noised_initial_guess = None in the init

Code quote:

self.noised_initial_guess

@pariterre pariterre changed the title [RTR] NoisedInitialGuess properly scale within bounds [RTM] NoisedInitialGuess properly scale within bounds Aug 4, 2022
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Ipuch)

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Ipuch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants