Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTR] Names of variables in figures handles variable mapping #524

Merged
merged 4 commits into from
Aug 25, 2022

Conversation

Ipuch
Copy link
Collaborator

@Ipuch Ipuch commented Aug 22, 2022

All Submissions:

  • Have you followed the guidelines in our Contributing document [docs/contribution.md]?
  • Have you checked to ensure there aren't other open [Pull Requests] for the same update/change?
  • Have you opened/linked the issue related to your pull request?
  • Have you used the tag [WIP] for on-going changes, and removed it when the pull request was ready?
  • When ready to merge, have you sent a comment pinging @pariterre in it?

New Feature Submissions:

  1. Does your submission pass the tests (if not please explain why this is intended)?
  2. Did you write a proper documentation (docstrings and ReadMe)
  3. Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new examples for your core changes, as applicable?
  • Have you written new tests for your core changes, as applicable?

related to #523


This change is Reviewable

@Ipuch Ipuch changed the title Names of variables in figures handles variable mapping [RTR] Names of variables in figures handles variable mapping Aug 22, 2022
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Base: 80.49% // Head: 83.86% // Increases project coverage by +3.37% 🎉

Coverage data is based on head (8ff7528) compared to base (e831e3a).
Patch coverage: 86.80% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #524      +/-   ##
==========================================
+ Coverage   80.49%   83.86%   +3.37%     
==========================================
  Files          87       88       +1     
  Lines        9552     9690     +138     
==========================================
+ Hits         7689     8127     +438     
+ Misses       1863     1563     -300     
Impacted Files Coverage Δ
bioptim/optimization/solution.py 85.56% <ø> (ø)
bioptim/gui/graph.py 95.20% <50.00%> (-0.27%) ⬇️
bioptim/dynamics/integrator.py 94.73% <69.23%> (-2.20%) ⬇️
...mples/getting_started/example_implicit_dynamics.py 89.47% <77.27%> (+44.54%) ⬆️
bioptim/dynamics/configure_problem.py 90.07% <77.94%> (-1.58%) ⬇️
bioptim/dynamics/dynamics_functions.py 96.32% <87.50%> (-1.85%) ⬇️
bioptim/limits/constraints.py 83.63% <97.50%> (+6.55%) ⬆️
bioptim/__init__.py 100.00% <100.00%> (ø)
bioptim/dynamics/dynamics_evaluation.py 100.00% <100.00%> (ø)
bioptim/dynamics/ode_solver.py 88.69% <100.00%> (+0.30%) ⬆️
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Ipuch)

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Ipuch)

@pariterre pariterre merged commit dcd7312 into pyomeca:master Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants