-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RTR] check if code is blacked independantly in github actions #530
Conversation
I've tested it here Ipuch/ode-solvers#1 it worked like this. 👍 |
This reverts commit 3efb17e.
Codecov ReportBase: 83.67% // Head: 83.65% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #530 +/- ##
==========================================
- Coverage 83.67% 83.65% -0.02%
==========================================
Files 89 89
Lines 9909 9914 +5
==========================================
+ Hits 8291 8294 +3
- Misses 1618 1620 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @Ipuch and @pariterre)
.github/workflows/autoblack.yml
line 18 at r2 (raw file):
python-version: 3.7 - name: Install Black run: pip install black
Change pip for conda
bioptim/examples/getting_started/pendulum.py
line 26 at r1 (raw file):
Solver, IntegralApproximation, DefectType,
To revert
Code quote:
IntegralApproximation,
DefectType,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Ipuch)
.github/workflows/autoblack.yml
line 33 at r3 (raw file):
git config --global user.email 'ipuch@users.noreply.github.com' git remote set-url origin https://x-access-token:${{ secrets.GITHUB_TOKEN }}@github.com/$GITHUB_REPOSITORY git checkout $GITHUB_HEAD_REF
Remove this
Code quote:
git config --global user.name 'autoblack'
git config --global user.email 'ipuch@users.noreply.github.com'
git remote set-url origin https://x-access-token:${{ secrets.GITHUB_TOKEN }}@github.com/$GITHUB_REPOSITORY
git checkout $GITHUB_HEAD_REF
git commit -am "fixup: Format Python code with Black"
git push
RTM @pariterre |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 3 files reviewed, 2 unresolved discussions (waiting on @pariterre)
.github/workflows/autoblack.yml
line 33 at r3 (raw file):
Previously, pariterre (Pariterre) wrote…
Remove this
Done
bioptim/examples/getting_started/pendulum.py
line 26 at r1 (raw file):
Previously, pariterre (Pariterre) wrote…
To revert
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try. Worst case scenario, we can remove this later!
Reviewed 1 of 2 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Ipuch)
Test if we can autoblack
This change is