Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTR] check if code is blacked independantly in github actions #530

Merged
merged 9 commits into from
Sep 19, 2022

Conversation

Ipuch
Copy link
Collaborator

@Ipuch Ipuch commented Aug 26, 2022

Test if we can autoblack


This change is Reviewable

@Ipuch Ipuch changed the title autoblack [WIP] autoblack Sep 8, 2022
@Ipuch Ipuch changed the title [WIP] autoblack [RTR] autoblack Sep 14, 2022
@Ipuch
Copy link
Collaborator Author

Ipuch commented Sep 14, 2022

I've tested it here Ipuch/ode-solvers#1 it worked like this. 👍

This reverts commit 3efb17e.
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Base: 83.67% // Head: 83.65% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (c419547) compared to base (c140068).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #530      +/-   ##
==========================================
- Coverage   83.67%   83.65%   -0.02%     
==========================================
  Files          89       89              
  Lines        9909     9914       +5     
==========================================
+ Hits         8291     8294       +3     
- Misses       1618     1620       +2     
Impacted Files Coverage Δ
bioptim/optimization/optimal_control_program.py 87.33% <0.00%> (-0.31%) ⬇️
bioptim/limits/penalty.py 91.85% <0.00%> (ø)
bioptim/dynamics/integrator.py 94.73% <0.00%> (ø)
bioptim/dynamics/ode_solver.py 88.69% <0.00%> (ø)
bioptim/optimization/optimization_vector.py 96.67% <0.00%> (ø)
bioptim/optimization/solution.py 86.06% <0.00%> (+0.02%) ⬆️
bioptim/limits/objective_functions.py 88.65% <0.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @Ipuch and @pariterre)


.github/workflows/autoblack.yml line 18 at r2 (raw file):

          python-version: 3.7
      - name: Install Black
        run: pip install black

Change pip for conda


bioptim/examples/getting_started/pendulum.py line 26 at r1 (raw file):

    Solver,
    IntegralApproximation,
    DefectType,

To revert

Code quote:

    IntegralApproximation,
    DefectType,

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Ipuch)


.github/workflows/autoblack.yml line 33 at r3 (raw file):

          git config --global user.email 'ipuch@users.noreply.github.com'
          git remote set-url origin https://x-access-token:${{ secrets.GITHUB_TOKEN }}@github.com/$GITHUB_REPOSITORY
          git checkout $GITHUB_HEAD_REF

Remove this

Code quote:

          git config --global user.name 'autoblack'
          git config --global user.email 'ipuch@users.noreply.github.com'
          git remote set-url origin https://x-access-token:${{ secrets.GITHUB_TOKEN }}@github.com/$GITHUB_REPOSITORY
          git checkout $GITHUB_HEAD_REF
          git commit -am "fixup: Format Python code with Black"
          git push

@Ipuch Ipuch changed the title [RTR] autoblack [RTR] check if code is blacked independantly Sep 16, 2022
@Ipuch Ipuch changed the title [RTR] check if code is blacked independantly [RTR] check if code is blacked independantly in github actions Sep 16, 2022
@Ipuch
Copy link
Collaborator Author

Ipuch commented Sep 16, 2022

RTM @pariterre

Copy link
Collaborator Author

@Ipuch Ipuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 3 files reviewed, 2 unresolved discussions (waiting on @pariterre)


.github/workflows/autoblack.yml line 33 at r3 (raw file):

Previously, pariterre (Pariterre) wrote…

Remove this

Done


bioptim/examples/getting_started/pendulum.py line 26 at r1 (raw file):

Previously, pariterre (Pariterre) wrote…

To revert

done

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try. Worst case scenario, we can remove this later!
:lgtm:

Reviewed 1 of 2 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Ipuch)

@pariterre pariterre merged commit 088d94c into pyomeca:master Sep 19, 2022
@Ipuch Ipuch deleted the pyomaster branch September 19, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants