[RTR] Implicit defect type for muscles

[Ipuch]

All Submissions:

• Have you followed the guidelines in our Contributing document [docs/contribution.md]?
• Have you checked to ensure there aren't other open [Pull Requests] for the same update/change?
• Have you opened/linked the issue related to your pull request?
• Have you used the tag [WIP] for on-going changes, and removed it when the pull request was ready?
• When ready to merge, have you sent a comment pinging @pariterre in it?

New Feature Submissions:

1. Does your submission pass the tests (if not please explain why this is intended)?
2. Did you write a proper documentation (docstrings and ReadMe)
3. Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new examples for your core changes, as applicable?
• Have you written new tests for your core changes, as applicable?

Cannot build the tests for muscles because master is not updated with #551

---

This change is 

[pariterre]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Ipuch)

---

bioptim/dynamics/dynamics_functions.py line 490 at r1 (raw file):

        defects = None
        # todo: contacts and fatigue to be handled with implicit dynamics

Put TODO in caps so we can easily find it

[Ipuch]

Don't merge, it's not tested 😀

[pariterre]

There is still the TODO in caps comment which is not resolved

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Ipuch)

[Ipuch]

Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @pariterre)

---

bioptim/dynamics/dynamics_functions.py line 490 at r1 (raw file):

Previously, pariterre (Pariterre) wrote…

Put TODO in caps so we can easily find it

Done.

[Ipuch]

It passed except for fatigue...

[codecov]

Codecov Report

Base: 80.47% // Head: 80.52% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (4791dad) compared to base (8136cc5).
Patch coverage: 96.29% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #561      +/-   ##
==========================================
+ Coverage   80.47%   80.52%   +0.05%     
==========================================
  Files          95       95              
  Lines       10382    10405      +23     
==========================================
+ Hits         8355     8379      +24     
+ Misses       2027     2026       -1     

Impacted Files	Coverage Δ
bioptim/dynamics/dynamics_functions.py	94.50% <94.11%> (-0.09%)	⬇️
bioptim/dynamics/configure_problem.py	90.09% <100.00%> (+0.02%)	⬆️
...es/muscle_driven_ocp/muscle_activations_tracker.py	76.14% <100.00%> (+0.90%)	⬆️
...es/muscle_driven_ocp/muscle_excitations_tracker.py	73.63% <100.00%> (+0.99%)	⬆️
bioptim/dynamics/integrator.py	95.90% <0.00%> (+1.16%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[Ipuch]

@pariterre approval?

[pariterre]

Reviewed 2 of 2 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Ipuch)