-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Variable scaling #572
Conversation
|
||
|
||
x_scaling = VariableScalingList() | ||
x_scaling.add("q", scaling=[1, 1]) # declare keys in order, so that they are concatenated in the right order |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you check if scaling is always positive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point
FYI, next time use the "Reviewable" button (as opposed to "Files changed") so we don't sparse the comments across two methods
I think I still need quite a bit of work on this PR, and now I need to work on other things. So I will take a break from this PR. TODO:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 33 of 33 files at r5, all commit messages.
Reviewable status: all files reviewed, 26 unresolved discussions (waiting on @EveCharbie and @mickaelbegon)
231f2cf
to
70d4ccc
Compare
The remainning failing tests are all (except for parameter) related to this hack in initializing noise. It also relates to the commit 7cb1ab2
…t (fixed Parameters test)
Codecov ReportBase: 81.60% // Head: 81.47% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #572 +/- ##
==========================================
- Coverage 81.60% 81.47% -0.13%
==========================================
Files 104 105 +1
Lines 11367 11703 +336
==========================================
+ Hits 9276 9535 +259
- Misses 2091 2168 +77
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
🎉 |
All Submissions:
New Feature Submissions:
black . -l120 --exclude "external/*"
)?Changes to Core Features:
This change is