Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTR] inverse defects on joint acceleration driven #577

Merged
merged 12 commits into from
Jan 12, 2023

Conversation

Ipuch
Copy link
Collaborator

@Ipuch Ipuch commented Nov 18, 2022

All Submissions:

  • Have you followed the guidelines in our Contributing document [docs/contribution.md]?
  • Have you checked to ensure there aren't other open [Pull Requests] for the same update/change?
  • Have you opened/linked the issue related to your pull request?
  • Have you used the tag [WIP] for on-going changes, and removed it when the pull request was ready?
  • When ready to merge, have you sent a comment pinging @pariterre in it?

New Feature Submissions:

  1. Does your submission pass the tests (if not please explain why this is intended)?
  2. Did you write a proper documentation (docstrings and ReadMe)
  3. Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new examples for your core changes, as applicable?
  • Have you written new tests for your core changes, as applicable?

This change is Reviewable

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 81.47% // Head: 81.48% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (e47b847) compared to base (fd9a1fb).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #577      +/-   ##
==========================================
+ Coverage   81.47%   81.48%   +0.01%     
==========================================
  Files         105      105              
  Lines       11703    11712       +9     
==========================================
+ Hits         9535     9544       +9     
  Misses       2168     2168              
Impacted Files Coverage Δ
bioptim/dynamics/configure_problem.py 90.97% <100.00%> (+0.04%) ⬆️
bioptim/dynamics/dynamics_functions.py 94.18% <100.00%> (+0.16%) ⬆️
bioptim/interfaces/solve_ivp_interface.py 96.77% <100.00%> (ø)
bioptim/optimization/solution.py 83.55% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ipuch Ipuch changed the title inverse defects on joint acceleration driven [WIP] inverse defects on joint acceleration driven Nov 23, 2022
@Ipuch Ipuch changed the title [WIP] inverse defects on joint acceleration driven [RTR] inverse defects on joint acceleration driven Dec 8, 2022
@Ipuch
Copy link
Collaborator Author

Ipuch commented Jan 5, 2023

@pariterre, ready to merge, if the tests pass.

@pariterre
Copy link
Member

They don't :P

@Ipuch
Copy link
Collaborator Author

Ipuch commented Jan 6, 2023

@pariterre now they do

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pariterre pariterre merged commit 8a14cf8 into pyomeca:master Jan 12, 2023
@Ipuch Ipuch deleted the joint_acecleration branch July 6, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants