Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTR] split final MHE save #592

Merged
merged 12 commits into from
Jan 18, 2023
Merged

[RTR] split final MHE save #592

merged 12 commits into from
Jan 18, 2023

Conversation

Ipuch
Copy link
Collaborator

@Ipuch Ipuch commented Jan 11, 2023

All Submissions:

  • Have you followed the guidelines in our Contributing document [docs/contribution.md]?
  • Have you checked to ensure there aren't other open [Pull Requests] for the same update/change?
  • Have you opened/linked the issue related to your pull request?
  • Have you used the tag [WIP] for on-going changes, and removed it when the pull request was ready?
  • When ready to merge, have you sent a comment pinging @pariterre in it?

New Feature Submissions:

  1. Does your submission pass the tests (if not please explain why this is intended)?
  2. Did you write a proper documentation (docstrings and ReadMe)
  3. Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new examples for your core changes, as applicable?
  • Have you written new tests for your core changes, as applicable?

This change is Reviewable

@Ipuch Ipuch added the enhancement New feature or request label Jan 11, 2023
@Ipuch Ipuch changed the title split final MHE save [WIP] split final MHE save Jan 11, 2023
@Ipuch
Copy link
Collaborator Author

Ipuch commented Jan 11, 2023

won't work yet because, when we move from one frame to another it make no sens to same this.
Only if frame to move is superior to 1, or only for multicyclic.

@Ipuch Ipuch changed the title [WIP] split final MHE save [RTR] split final MHE save Jan 11, 2023
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Base: 81.47% // Head: 81.54% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (a4b80e6) compared to base (fd9a1fb).
Patch coverage: 97.29% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #592      +/-   ##
==========================================
+ Coverage   81.47%   81.54%   +0.06%     
==========================================
  Files         105      105              
  Lines       11703    11739      +36     
==========================================
+ Hits         9535     9572      +37     
+ Misses       2168     2167       -1     
Impacted Files Coverage Δ
bioptim/examples/moving_horizon_estimation/mhe.py 50.87% <0.00%> (ø)
bioptim/interfaces/solve_ivp_interface.py 96.77% <100.00%> (ø)
...ptim/optimization/receding_horizon_optimization.py 94.94% <100.00%> (+1.00%) ⬆️
bioptim/optimization/solution.py 83.58% <100.00%> (+0.02%) ⬆️
bioptim/dynamics/configure_problem.py 90.97% <0.00%> (+0.04%) ⬆️
bioptim/dynamics/dynamics_functions.py 94.18% <0.00%> (+0.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

_states, _controls = self.export_cycles(sol)
cycle_solutions.append(self._initialize_one_cycle(_states, _controls))

if get_all_iterations and get_cycles:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out = []
if get_all_interations:
out.append(...)
if ...:
out.append(...)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@Ipuch
Copy link
Collaborator Author

Ipuch commented Jan 12, 2023

@pariterre

@pariterre pariterre merged commit a8bd91d into pyomeca:master Jan 18, 2023
@Ipuch Ipuch deleted the mhe_window_save branch July 6, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants