Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable naming #597

Merged
merged 2 commits into from
Jan 19, 2023
Merged

Fix variable naming #597

merged 2 commits into from
Jan 19, 2023

Conversation

Ipuch
Copy link
Collaborator

@Ipuch Ipuch commented Jan 18, 2023

related to #593 i think so.


This change is Reviewable

@Ipuch Ipuch added the bug Something isn't working label Jan 18, 2023
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Base: 81.54% // Head: 81.54% // No change to project coverage 👍

Coverage data is based on head (ebd4c7d) compared to base (a4b80e6).
Patch coverage: 94.44% of modified lines in pull request are covered.

❗ Current head ebd4c7d differs from pull request most recent head 9e9b6a1. Consider uploading reports for the commit 9e9b6a1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #597   +/-   ##
=======================================
  Coverage   81.54%   81.54%           
=======================================
  Files         105      105           
  Lines       11739    11739           
=======================================
  Hits         9572     9572           
  Misses       2167     2167           
Impacted Files Coverage Δ
bioptim/dynamics/configure_problem.py 90.97% <90.90%> (ø)
bioptim/dynamics/dynamics_functions.py 94.18% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pariterre pariterre merged commit 578373c into pyomeca:master Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants