Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passive torque example #626

Merged
merged 21 commits into from
Mar 6, 2023
Merged

Conversation

AntoineLeroy
Copy link
Contributor

@AntoineLeroy AntoineLeroy commented Feb 24, 2023

All Submissions:

  • Have you followed the guidelines in our Contributing document [docs/contribution.md]?
  • Have you checked to ensure there aren't other open [Pull Requests] for the same update/change?
  • Have you opened/linked the issue related to your pull request?
  • Have you used the tag [WIP] for on-going changes, and removed it when the pull request was ready?
  • When ready to merge, have you sent a comment pinging @pariterre in it?

New Feature Submissions:

  1. Does your submission pass the tests (if not please explain why this is intended)?
  2. Did you write a proper documentation (docstrings and ReadMe)
  3. Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new examples for your core changes, as applicable?
  • Have you written new tests for your core changes, as applicable?

This change is Reviewable

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Patch coverage: 85.71% and project coverage change: +0.01 🎉

Comparison is base (354ee4e) 81.69% compared to head (de14c12) 81.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #626      +/-   ##
==========================================
+ Coverage   81.69%   81.70%   +0.01%     
==========================================
  Files         107      108       +1     
  Lines       11849    11924      +75     
==========================================
+ Hits         9680     9743      +63     
- Misses       2169     2181      +12     
Impacted Files Coverage Δ
.../torque_driven_ocp/pendulum_with_passive_torque.py 65.71% <60.00%> (-5.72%) ⬇️
...amples/torque_driven_ocp/ocp_mass_with_ligament.py 75.75% <75.75%> (ø)
bioptim/limits/constraints.py 83.21% <83.33%> (+0.24%) ⬆️
bioptim/dynamics/configure_problem.py 91.30% <100.00%> (+0.15%) ⬆️
bioptim/dynamics/dynamics_functions.py 94.54% <100.00%> (+0.16%) ⬆️
bioptim/dynamics/ode_solver.py 89.25% <100.00%> (+0.56%) ⬆️
...xamples/getting_started/example_external_forces.py 88.23% <100.00%> (+0.35%) ⬆️
bioptim/interfaces/biomodel.py 100.00% <100.00%> (ø)
bioptim/interfaces/biorbd_model.py 94.79% <100.00%> (+0.03%) ⬆️
bioptim/limits/objective_functions.py 88.71% <100.00%> (+0.05%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AntoineLeroy AntoineLeroy changed the title [WIP] Fix passive torque example [RTR] Fix passive torque example Feb 24, 2023
@pariterre
Copy link
Member

Why is there ligament stuff in this PR?

pariterre
pariterre previously approved these changes Mar 2, 2023
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 8 files at r1, 1 of 3 files at r2, 12 of 12 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AntoineLeroy)

@pariterre pariterre changed the title [RTR] Fix passive torque example Fix passive torque example Mar 2, 2023
pariterre
pariterre previously approved these changes Mar 2, 2023
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AntoineLeroy)

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r7, 1 of 2 files at r8, 1 of 2 files at r9, 1 of 1 files at r11, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AntoineLeroy)

@pariterre pariterre merged commit 61f2438 into pyomeca:master Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants