-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RTM if tests pass] inverse OCP #635
Conversation
@pariterre I will not create a full test because it would be too long. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #635 +/- ##
==========================================
- Coverage 81.91% 81.56% -0.35%
==========================================
Files 109 110 +1
Lines 12140 12341 +201
==========================================
+ Hits 9944 10066 +122
- Misses 2196 2275 +79
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@pariterre, we might need to change the dependencies in conda-forge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 4 files at r1, 4 of 5 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @EveCharbie)
README.md
line 114 at r3 (raw file):
- [Moving estimation horizon](#moving-estimation-horizon) - [Acados](#acados) - [Inverse_optimal_control](#inverse_optimal_control)
Normal casing? make sure this links work
Code quote:
Inverse_optimal_control
tests/test_all_examples.py
line 499 at r3 (raw file):
def test__inverse_optimal_control__doublep_endulum_torque_driven_IOCP():
Suggestion:
double_pendulum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @pariterre)
README.md
line 114 at r3 (raw file):
Previously, pariterre (Pariterre) wrote…
Normal casing? make sure this links work
Done.
tests/test_all_examples.py
line 499 at r3 (raw file):
def test__inverse_optimal_control__doublep_endulum_torque_driven_IOCP():
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @EveCharbie)
README.md
line 114 at r3 (raw file):
Previously, EveCharbie (Eve Charbonneau) wrote…
Done.
I don't see the difference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 5 of 8 files reviewed, 1 unresolved discussion (waiting on @pariterre)
README.md
line 114 at r3 (raw file):
Previously, pariterre (Pariterre) wrote…
I don't see the difference
Just wait 1sec, I am committing XD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @EveCharbie)
All Submissions:
New Feature Submissions:
black . -l120 --exclude "external/*"
)?Changes to Core Features:
This change is