Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTM if tests pass] inverse OCP #635

Merged
merged 18 commits into from
Mar 16, 2023

Conversation

EveCharbie
Copy link
Collaborator

@EveCharbie EveCharbie commented Mar 9, 2023

All Submissions:

  • Have you followed the guidelines in our Contributing document [docs/contribution.md]?
  • Have you checked to ensure there aren't other open [Pull Requests] for the same update/change?
  • Have you opened/linked the issue related to your pull request?
  • Have you used the tag [WIP] for on-going changes, and removed it when the pull request was ready?
  • When ready to merge, have you sent a comment pinging @pariterre in it?

New Feature Submissions:

  1. Does your submission pass the tests (if not please explain why this is intended)?
  2. Did you write a proper documentation (docstrings and ReadMe)
  3. Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new examples for your core changes, as applicable?
  • Have you written new tests for your core changes, as applicable?

This change is Reviewable

@EveCharbie
Copy link
Collaborator Author

@pariterre I will not create a full test because it would be too long.
But, do I create smaller tests to make sure that this example evolves with the rest of bioptim? If yes, is ti an inconvenience if we now have to install pygmo?

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch coverage: 79.55% and project coverage change: -0.35 ⚠️

Comparison is base (936813d) 81.91% compared to head (9d90027) 81.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #635      +/-   ##
==========================================
- Coverage   81.91%   81.56%   -0.35%     
==========================================
  Files         109      110       +1     
  Lines       12140    12341     +201     
==========================================
+ Hits         9944    10066     +122     
- Misses       2196     2275      +79     
Impacted Files Coverage Δ
...xamples/getting_started/example_external_forces.py 88.23% <ø> (ø)
...imal_control/double_pendulum_torque_driven_IOCP.py 37.06% <37.06%> (ø)
bioptim/limits/phase_transition.py 92.22% <50.00%> (ø)
.../torque_driven_ocp/pendulum_with_passive_torque.py 65.71% <60.00%> (ø)
...es/torque_driven_ocp/example_multi_biorbd_model.py 72.72% <72.72%> (ø)
...amples/torque_driven_ocp/ocp_mass_with_ligament.py 75.75% <75.75%> (ø)
bioptim/limits/constraints.py 83.21% <80.00%> (ø)
bioptim/misc/mapping.py 90.67% <89.74%> (+1.10%) ⬆️
bioptim/interfaces/biorbd_model.py 96.01% <95.58%> (ø)
bioptim/__init__.py 100.00% <100.00%> (ø)
... and 5 more

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@EveCharbie EveCharbie changed the title [WIP] inverse OCP [RTR] inverse OCP Mar 13, 2023
@EveCharbie
Copy link
Collaborator Author

@pariterre, we might need to change the dependencies in conda-forge?

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 4 files at r1, 4 of 5 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @EveCharbie)


README.md line 114 at r3 (raw file):

- [Moving estimation horizon](#moving-estimation-horizon)
- [Acados](#acados)
- [Inverse_optimal_control](#inverse_optimal_control)

Normal casing? make sure this links work

Code quote:

Inverse_optimal_control

tests/test_all_examples.py line 499 at r3 (raw file):

def test__inverse_optimal_control__doublep_endulum_torque_driven_IOCP():

Suggestion:

double_pendulum

@pariterre pariterre changed the title [RTR] inverse OCP inverse OCP Mar 16, 2023
Copy link
Collaborator Author

@EveCharbie EveCharbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @pariterre)


README.md line 114 at r3 (raw file):

Previously, pariterre (Pariterre) wrote…

Normal casing? make sure this links work

Done.


tests/test_all_examples.py line 499 at r3 (raw file):

def test__inverse_optimal_control__doublep_endulum_torque_driven_IOCP():

Done.

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @EveCharbie)


README.md line 114 at r3 (raw file):

Previously, EveCharbie (Eve Charbonneau) wrote…

Done.

I don't see the difference

Copy link
Collaborator Author

@EveCharbie EveCharbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 5 of 8 files reviewed, 1 unresolved discussion (waiting on @pariterre)


README.md line 114 at r3 (raw file):

Previously, pariterre (Pariterre) wrote…

I don't see the difference

Just wait 1sec, I am committing XD

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @EveCharbie)

@EveCharbie EveCharbie changed the title inverse OCP [RTM if tests pass] inverse OCP Mar 16, 2023
@pariterre pariterre merged commit 4acdea0 into pyomeca:master Mar 16, 2023
@EveCharbie EveCharbie deleted the InverseOCP_example branch May 30, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants