Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTM] moving test to make windows test pass #640

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

Ipuch
Copy link
Collaborator

@Ipuch Ipuch commented Mar 30, 2023

see title


This change is Reviewable

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage: 94.54% and project coverage change: +0.01 🎉

Comparison is base (b791f4d) 81.52% compared to head (8ce301c) 81.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #640      +/-   ##
==========================================
+ Coverage   81.52%   81.53%   +0.01%     
==========================================
  Files         110      110              
  Lines       12315    12333      +18     
==========================================
+ Hits        10040    10056      +16     
- Misses       2275     2277       +2     
Impacted Files Coverage Δ
bioptim/gui/check_conditioning.py 85.53% <0.00%> (ø)
bioptim/limits/penalty.py 91.11% <66.66%> (-0.31%) ⬇️
bioptim/optimization/optimization_variable.py 87.63% <92.85%> (+0.13%) ⬆️
bioptim/dynamics/integrator.py 95.67% <100.00%> (+0.05%) ⬆️
bioptim/dynamics/ode_solver.py 89.07% <100.00%> (-0.19%) ⬇️
bioptim/interfaces/solve_ivp_interface.py 96.80% <100.00%> (+0.03%) ⬆️
bioptim/optimization/non_linear_program.py 90.57% <100.00%> (+0.20%) ⬆️
bioptim/optimization/optimization_vector.py 95.73% <100.00%> (+0.01%) ⬆️
bioptim/optimization/solution.py 83.65% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ipuch Ipuch changed the title moving test to make windows test pass [RTM] moving test to make windows test pass Mar 30, 2023
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Ipuch)

@pariterre pariterre merged commit 2d75369 into pyomeca:master Apr 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants