Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed default value for show_online #661

Merged
merged 3 commits into from
May 4, 2023
Merged

Conversation

pariterre
Copy link
Member

@pariterre pariterre commented May 3, 2023

All Submissions:

  • Have you followed the guidelines in our Contributing document [docs/contribution.md]?
  • Have you checked to ensure there aren't other open [Pull Requests] for the same update/change?
  • Have you opened/linked the issue related to your pull request?
  • Have you used the tag [WIP] for on-going changes, and removed it when the pull request was ready?
  • When ready to merge, have you sent a comment pinging @pariterre in it?

New Feature Submissions:

  1. Does your submission pass the tests (if not please explain why this is intended)?
  2. Did you write a proper documentation (docstrings and ReadMe)
  3. Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new examples for your core changes, as applicable?
  • Have you written new tests for your core changes, as applicable?

This change is Reviewable

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch coverage: 48.64% and no project coverage change.

Comparison is base (3c1fbec) 81.33% compared to head (9575bea) 81.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #661   +/-   ##
=======================================
  Coverage   81.33%   81.33%           
=======================================
  Files         112      112           
  Lines       12696    12706   +10     
=======================================
+ Hits        10326    10335    +9     
- Misses       2370     2371    +1     
Impacted Files Coverage Δ
bioptim/interfaces/interface_utils.py 83.50% <0.00%> (ø)
...getting_started/example_continuity_as_objective.py 47.43% <33.33%> (+0.68%) ⬆️
bioptim/examples/fatigue/pendulum_with_fatigue.py 82.60% <50.00%> (ø)
...ioptim/examples/fatigue/static_arm_with_fatigue.py 67.85% <50.00%> (ø)
...ptim/examples/getting_started/custom_constraint.py 87.50% <50.00%> (+0.32%) ⬆️
...ioptim/examples/getting_started/custom_dynamics.py 88.37% <50.00%> (ø)
...ptim/examples/getting_started/custom_objectives.py 84.21% <50.00%> (+0.42%) ⬆️
...amples/getting_started/custom_phase_transitions.py 92.53% <50.00%> (ø)
...xamples/getting_started/example_cyclic_movement.py 85.71% <50.00%> (ø)
...xamples/getting_started/example_external_forces.py 88.23% <50.00%> (ø)
... and 27 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pariterre pariterre merged commit f8a1f1b into pyomeca:master May 4, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant