Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTR] empty initial guess / scaling problem #666

Merged
merged 15 commits into from
May 9, 2023

Conversation

EveCharbie
Copy link
Collaborator

@EveCharbie EveCharbie commented May 5, 2023

Modified the error message in response to issue #622.


This change is Reviewable

@EveCharbie EveCharbie changed the title empty initial guess / scaling problem [waiting for tests to pass] empty initial guess / scaling problem May 8, 2023
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage: 90.00% and project coverage change: +0.45 🎉

Comparison is base (5ed2dbd) 81.11% compared to head (adaf73e) 81.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #666      +/-   ##
==========================================
+ Coverage   81.11%   81.57%   +0.45%     
==========================================
  Files         112      112              
  Lines       12906    12949      +43     
==========================================
+ Hits        10469    10563      +94     
+ Misses       2437     2386      -51     
Impacted Files Coverage Δ
...ptim/optimization/receding_horizon_optimization.py 94.20% <75.00%> (-0.90%) ⬇️
bioptim/optimization/optimal_control_program.py 86.80% <100.00%> (+0.22%) ⬆️
bioptim/optimization/optimization_variable.py 87.54% <100.00%> (+6.83%) ⬆️

... and 34 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@EveCharbie EveCharbie changed the title [waiting for tests to pass] empty initial guess / scaling problem [RTR] empty initial guess / scaling problem May 9, 2023
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 1 of 2 files at r2, 1 of 2 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @EveCharbie)

@pariterre pariterre merged commit 55a2d78 into pyomeca:master May 9, 2023
7 checks passed
@EveCharbie EveCharbie deleted the bug_automatic_scaling branch August 2, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants