Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTR] bug with derivative=True and node=Node.ALL #670

Merged
merged 1 commit into from
May 8, 2023

Conversation

EveCharbie
Copy link
Collaborator

@EveCharbie EveCharbie commented May 5, 2023

I think I fixed the issue #620


This change is Reviewable

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage: 75.00% and no project coverage change.

Comparison is base (9cb855b) 81.41% compared to head (82afdaa) 81.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #670   +/-   ##
=======================================
  Coverage   81.41%   81.41%           
=======================================
  Files         112      112           
  Lines       12874    12875    +1     
=======================================
+ Hits        10481    10482    +1     
  Misses       2393     2393           
Impacted Files Coverage Δ
bioptim/interfaces/interface_utils.py 83.58% <75.00%> (+0.08%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@EveCharbie EveCharbie changed the title bug with derivative=True and node=Node.ALL [RTR] bug with derivative=True and node=Node.ALL May 8, 2023
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna trust you on this one!
:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @EveCharbie)

@pariterre pariterre merged commit d97c250 into pyomeca:master May 8, 2023
6 of 7 checks passed
@EveCharbie EveCharbie deleted the bug_derivative_scalign branch August 2, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants