[WIP] Bis Min_max_torque (Pariterre to fix) #683
Conversation
the parameter contraint is only applyed to the first phase (bug to be fixed)
Might be wrong bu committing for the form
RuntimeError: Error in Function::call for 'PHASE_TRANSITION_CONTINUOUS_0_1' [MXFunction] at .../casadi/core/function.cpp:330:
.../casadi/core/function_internal.hpp:1644: Input 1 (i1) has mismatching shape. Got 6-by-1. Allowed dimensions, in general, are:
- The input dimension N-by-M (here 3-by-1)
- A scalar, i.e. 1-by-1
- M-by-N if N=1 or M=1 (i.e. a transposed vector)
- N-by-M1 if K*M1=M for some K (argument repeated horizontally)
- N-by-P*M, indicating evaluation with multiple arguments (P must be a multiple of 1 for consistency with previous inputs)
|
There was a problem hiding this comment.
Reviewed 25 of 25 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @EveCharbie)
bioptim/examples/torque_driven_ocp/minimize_maximum_torque_by_extra_parameter.py line 1 at r1 (raw file):
import numpy as np
Add a description?
bioptim/optimization/parameters.py line 109 at r1 (raw file):
return self.cx.shape[0] def add_or_replace_to_parameter_penalty_pool(self, ocp, penalty):
keep previous naming convention to reflect on Penalty
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @pariterre)
bioptim/examples/torque_driven_ocp/minimize_maximum_torque_by_extra_parameter.py line 1 at r1 (raw file):
Previously, pariterre (Pariterre) wrote…
Add a description?
Done.
bioptim/optimization/parameters.py line 109 at r1 (raw file):
Previously, pariterre (Pariterre) wrote…
keep previous naming convention to reflect on Penalty
Done.
pariterre
changed the title
All comments from the other PR were addressed (the other branch can be deleted)
This change is